Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSL100 transpiling fails to convert 'in highp float myVariable' #1602

Open
MGraefe opened this issue Jan 20, 2022 · 1 comment
Open

GLSL100 transpiling fails to convert 'in highp float myVariable' #1602

MGraefe opened this issue Jan 20, 2022 · 1 comment

Comments

@MGraefe
Copy link

MGraefe commented Jan 20, 2022

Using luma.gl 8.5.10, transpiling of the following line of shader code to GLSL100 leaves the following line unchanged:

in highp float myVariable;

This then produces a compilation error:

ERROR: 'in' : storage qualifier supported in GLSL ES 3.00 and above only

Instead, this line should be transpiled to:

attribute highp float myVariable;

I believe it did so for older luma.gl versions, at least our problems only popped up after updating deck (and thus luma).
Probably not really an urgent bug, especially because slapping on 'precision highp float' and calling it a day works just fine on modern platforms and it would probably even work without any precision specifier at all. Just wanted to document this.

@ilan-gold
Copy link

I saw this as well: #1624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants