We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFInstantiator.instantiate adds _node and _mesh fields to node and mesh:
GLTFInstantiator.instantiate
_node
_mesh
luma.gl/modules/experimental/src/gltf/gltf-instantiator.js
Line 60 in c2f0534
Lines 99 to 100 in c2f0534
This prevents the gltf object from being used to create another instance, and there is no easy way to undo this change.
Input object should not be mutated.
visgl/deck.gl#7950
The text was updated successfully, but these errors were encountered:
I suppose a quick fix for 8.5 would be to deep clone everything (except arraybuffers) before instantiating.
That is probabely appropriate since for 9.0 the gltf instantiation needs to be refactored quite extensively.
Sorry, something went wrong.
No branches or pull requests
Actual Result
GLTFInstantiator.instantiate
adds_node
and_mesh
fields to node and mesh:luma.gl/modules/experimental/src/gltf/gltf-instantiator.js
Line 60 in c2f0534
luma.gl/modules/experimental/src/gltf/gltf-instantiator.js
Lines 99 to 100 in c2f0534
This prevents the gltf object from being used to create another instance, and there is no easy way to undo this change.
Expected Result
Input object should not be mutated.
Reproduce Steps
visgl/deck.gl#7950
To Do List
The text was updated successfully, but these errors were encountered: