Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Shader Module getUniforms semantics #1908

Open
ibgreen opened this issue Jan 9, 2024 · 0 comments
Open

Clean up Shader Module getUniforms semantics #1908

ibgreen opened this issue Jan 9, 2024 · 0 comments

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Jan 9, 2024

PR #1907 is a change to the shader module getUniform semantics - an empty call no longer generates uniforms. I think it is a good change (though the system is still a bit messy).

Also this default value handling was previously handled by the getUniforms function returned by the shader assembler.

Would be good to

  • see if we can remove the old shader assembler getUniforms code so we don't have divergent semantics in different places.
  • make sure the documentation reflects the latest semantics
  • if needed, add an upgrade guide note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant