Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrc-get upgradeでlockedの空のdependenciesキーが削除される? #473

Closed
Narazaka opened this issue Feb 29, 2024 · 1 comment · Fixed by #478
Closed

vrc-get upgradeでlockedの空のdependenciesキーが削除される? #473

Narazaka opened this issue Feb 29, 2024 · 1 comment · Fixed by #478
Labels
bug Something isn't working vrc-get-vpm vpm core module

Comments

@Narazaka
Copy link

Narazaka commented Feb 29, 2024

Description of the bug / バグの説明

VCCでAAO 1.6.6->1.6.7にアップグレードした差分
image
vrc-getでAAO 1.6.6->1.6.7にアップグレードした差分
image

順序差についてはjson同義なので良いと思うが、dependenciesキーがなくなる点についてはjson同義でないため気になった

あとこのissueとは別だがVCCがdependenciesキー内もアプデするようになったっぽいのか……?

Steps to Reproduce / 再現手順

PS D:\make\devel\vrchat-avatar-template-2022-vrm> vrc-get upgrade com.anatawa12.avatar-optimizer
[2024-02-29T16:52:10Z ERROR vrc_get_vpm::environment::repo_holder] fetching remote repo 'https://www.dreadrith.com/': expected value at line 1 column 1
You're installing the following packages:
- com.anatawa12.avatar-optimizer version 1.6.7
upgraded com.anatawa12.avatar-optimizer to 1.6.7
PS D:\make\devel\vrchat-avatar-template-2022-vrm>

Expected Behavior / 想定される挙動

json同義であるのが望ましい

Software Version / バージョン情報

1.7.0

OS

Windows 10 Pro 22H2

Additional context / 補足

No response

@Narazaka Narazaka added bug Something isn't working vrc-get cli vrc-get cli labels Feb 29, 2024
@anatawa12 anatawa12 changed the title vrc-get upgradeで空のdependenciesキーが削除される? vrc-get upgradeでlockedの空のdependenciesキーが削除される? Feb 29, 2024
@anatawa12
Copy link
Member

vrc-get実装当初はVpm側が追加しなかったので変わったやつですね...

順番は多分 vrchat-community/creator-companion#406 ですね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vrc-get-vpm vpm core module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants