Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to migrate non-curated tools to curated packages on the migration? #864

Open
anatawa12 opened this issue Apr 28, 2024 · 2 comments
Open
Labels
enhancement New feature or request vrc-get-gui Issues for vrc-get-gui

Comments

@anatawa12
Copy link
Member

Summary / 概要

For vrchat-curated packages, the vpm migration will migrate legacy packages to vpm maintained packages.
It might be useful to migrate non-vrchat-curated packages to vpm installation.

Purpose / 目的

We can easily migrate liltoon or some other tools / shaders easily

Additional context / 補足

No response

@anatawa12 anatawa12 added enhancement New feature or request vrc-get-gui Issues for vrc-get-gui labels Apr 28, 2024
@Spokeek
Copy link
Contributor

Spokeek commented May 9, 2024

Shouldn't this be defined within the legacyFolder option of the VPM spec ?
Or are you implying to "manually" add those packages on the migrated project to replace the old packages ?

@anatawa12
Copy link
Member Author

The VCC and ALCOM will migrate an unitypackage-based package to vpm package by checking legacy folders.
If legacyFolders of an package are found, VCC will install the package and (as if we installed manually) VCC will remove the unitypackage-based package by removing legacy folders.

The legacyFolders should point the folder contains package only so the migration should be safe.

Shouldn't this be defined within the legacyFolder option of the VPM spec ?

Do you mean it should be optional to use specific legacyFolders entry to be used in auto migration or not?

Or are you implying to "manually" add those packages on the migrated project to replace the old packages ?

No, removing legacy unitypackage-based package on manual installation is already implement as legacyFolders and legacyFiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vrc-get-gui Issues for vrc-get-gui
Projects
Status: No status
Development

No branches or pull requests

2 participants