Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml comments break xml parsing #6

Open
velcrome opened this issue Nov 26, 2016 · 1 comment
Open

xml comments break xml parsing #6

velcrome opened this issue Nov 26, 2016 · 1 comment

Comments

@velcrome
Copy link

velcrome commented Nov 26, 2016

The following vpack will not download ZeroMQ, because of the commented dependency.

It will process nicely without the comment, so I think this is a bug.

<vpack>
  <meta>
    <name>vvvv-ZeroMQ</name>
    <source>https://github.com/velcrome/vvvv-ZeroMQ</source>
    <author>velcrome</author>
    <dependencies>
      <!--dependency>
        <name>vvvv-Message</name>
        <source>vpms://raw.githubusercontent.com/velcrome/vvvv-Message/develop/copy/vvvv-Message.vpack</source>
      </dependency-->
    </dependencies>
  </meta>
  <install>
    Download(
      "https://github.com/velcrome/vvvv-ZeroMQ/releases/download/0.5.1/vvvv-ZeroMQ.zip",
      VPM.TempDir + "\\vvvv-ZeroMQ.zip"
    );
    Extract(VPM.TempDir + "\\vvvv-ZeroMQ.zip", Pack.TempDir + "\\extract");
	  CopyDir(
	    Pack.TempDir + "\\extract",
	    VVVV.Dir + "\\packs\\vvvv-ZeroMQ"
	  );
  </install>
</vpack>

Note that this behaviour is recursive, if there is a similar error in the dependency's vpm

@microdee
Copy link
Member

I just noticed this one now very strange I'm using regular .net xml parser, I thought it takes care of that. will have a look when I find time for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants