Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementering av CommitRequest-modellen #99

Open
oleander opened this issue Mar 13, 2012 · 6 comments
Open

Implementering av CommitRequest-modellen #99

oleander opened this issue Mar 13, 2012 · 6 comments
Assignees
@spontus
Milestone
Submission

Comments

@oleander
Copy link
Member

CommitRequest-modellen är inte helt färdigimplementerad. Följande saker behövs.

  • Validera ingående branch. Finns den? Om nej, får den skapas?
  • CommitRequest#save ska bara kunna köras en gång med givna parametrar, annars finns risk att flera versionen av samma data pushas till CommitRequestProcess-klassen.
  • Commit-meddelandet, några slags restriktioner bör finnas, te.x min-längd.
  • Stöd för filuppladdning. Filerna bör läsas in och "pushas" till beanstalkd enligt Förslag på data genom beanstalkd #21.
  • Validera filnamn enligt Skapa regexp för tillåtna filnamn #24
@ghost ghost assigned spontus Mar 13, 2012
@oleander
Copy link
Member Author

@spontus Hur går de?

@karinsofia
Copy link
Member

Regexp issuen: #24

@spontus
Copy link
Member

spontus commented Mar 22, 2012

Hur kollar man om det redan har körts save med vissa parametrar, går det att fråga beanstalk om den har fått viss data?

spontus added a commit that referenced this issue Mar 22, 2012
@spontus
Read in files for beanstalk #99
8b0d8e3
@oleander
Copy link
Member Author 

@cache[attributes.to_s] ||= publish(...)

Glöm inte att köra @cache = {} vid initiering.

oleander added a commit that referenced this issue Mar 26, 2012
@oleander
Clean up related to commit request model and controller [#99]
75f3dd7 
1. Removed invalid indentation
2. Use the short File.read when reading files
3. Follow the CommitRequestProcess spec
4. Truncate database on each CommitRequest spec loop
@oleander oleander mentioned this issue Mar 26, 2012
Closed
@oleander oleander reopened this Mar 26, 2012
@oleander
Copy link
Member Author

Den här issuen är inte klar än.
Det fattas bl.a ett flertal tester.

@oleander
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spontus spontus

Labels
None yet
Projects
None yet
Milestone
Submission
Development

No branches or pull requests
3 participants
@oleander @karinsofia @spontus