Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Save button to 'New Notes' page #6

Open
rkishan516 opened this issue Jun 9, 2019 · 4 comments
Open

Add a Save button to 'New Notes' page #6

rkishan516 opened this issue Jun 9, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rkishan516
Copy link
Collaborator

Add a Save button to 'New Notes' page and use material design for that.
@rkishan516 rkishan516 added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2019
@rkishan516
Copy link
Collaborator Author

What kind of doubt ?

@wdlsvnit wdlsvnit deleted a comment from auron567 Jul 4, 2019
@auron567
Copy link

auron567 commented Jul 4, 2019

  1. Clicking on the save button must end the Activity and return to the main list?
  2. I noticed that currently if a new note is opened and no value is set, the note is saved with empty values. Wouldn't it be better to save the note only in case of clicking on the save button? The new note should not be saved by going back directly.
  3. Can the button be a fab?

@rkishan516
Copy link
Collaborator Author

Yes, clicking on save button end the activity and return to main list and only by clicking we have to save the note but button should be part of AppBar.

@auron567
Copy link

auron567 commented Jul 4, 2019

Thanks for the clarifications, I start working

@auron567 auron567 mentioned this issue Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auron567 @rkishan516