Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-interventions response #136

Open
magsout opened this issue Jun 9, 2020 · 2 comments
Open

firefox-interventions response #136

magsout opened this issue Jun 9, 2020 · 2 comments
Labels
question Further information is requested

Comments

@magsout
Copy link
Member

magsout commented Jun 9, 2020

@denschub is it possible to send an error when client doesn't send all filters required? Right now, the api send an empty response.

@magsout magsout added the question Further information is requested label Jun 9, 2020
@magsout
Copy link
Member Author

magsout commented Jun 9, 2020

@magsout magsout changed the title andpoint interventions firefox-interventions response Jun 9, 2020
@denschub
Copy link
Member

denschub commented Jun 9, 2020

Sure, I could do that. For the moment, it looks like no endpoint is doing any kind of error handling, as https://webcompat-metrics.herokuapp.com/data/needstriage-timeline?from=2020-05-09 for example just 404s, but if you'd prefer that, I don't see a reason not to throw some error. I don't know if there is some kind of design decision behind not really doing error handling, or if this is just "nobody did it yet", so I'll leave this decision to someone else. Happy to implement it, though, if we need it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants