Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a test suite and Travis CI #21

Open
1 of 2 tasks
whphhg opened this issue Jun 19, 2017 · 2 comments
Open
1 of 2 tasks

Implement a test suite and Travis CI #21

whphhg opened this issue Jun 19, 2017 · 2 comments

Comments

@whphhg
Copy link
Owner

whphhg commented Jun 19, 2017

Research and implement the currently best approach for React and MobX testing. Then add
continuous integration using Travis CI.

  • Test suite
  • TravisCI (thanks to @sum01)
@whphhg whphhg self-assigned this Jun 19, 2017
@JohnVonNeumann
Copy link

Haven't really participated in this type of stuff before, but what are you estimating timespan wise for this? I'm happy to help out with the research and whatnot. Happy to get some pointers.

@whphhg
Copy link
Owner Author

whphhg commented Jun 20, 2017

Hej, thanks for the interest in helping!

I'd say roughly a week to get everything tested and go through a couple of cleanups to reach the cleanest version possible, no bloat (provided you're familiar with the source). I'd begin by testing the components first, then move to more complex stores like wallet/send.

A good place to start researching would be https://mobx.js.org/faq/blogs.html. As I copied the URL I saw How to Test React and MobX with Jest in the tutorials section. That's where I'd start, see if it's still the best approach or if there's something else being used now and go from there.

whphhg pushed a commit that referenced this issue Nov 23, 2017
npm test is commented out until #21 is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants