Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery temporary required in devDependencies #35

Open
whphhg opened this issue Jan 24, 2018 · 0 comments
Open

jQuery temporary required in devDependencies #35

whphhg opened this issue Jan 24, 2018 · 0 comments
Assignees
@whphhg
Labels
bug

Comments

@whphhg
Copy link
Owner

whphhg commented Jan 24, 2018 •
edited

jquery is temporary required in devDependencies for successful use of electron-builder, until issue electron-userland/electron-builder#2236 is resolved. The reason is antd@2.13.11, which has jquery listed in peerDependencies, but it is not used by any React component being imported from antd.

npm WARN slick-carousel@1.8.1 requires a peer of jquery@>=1.8.0 but none is installed. You must install peer dependencies yourself.

Added in commit e8493fe.
@whphhg whphhg added the bug label Jan 24, 2018
@whphhg whphhg self-assigned this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whphhg whphhg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whphhg