Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: use i18n #2

Open
meodai opened this issue Sep 7, 2021 · 2 comments
Open

Feat: use i18n #2

meodai opened this issue Sep 7, 2021 · 2 comments

Comments

@meodai
Copy link
Contributor

meodai commented Sep 7, 2021

Make sure the descriptions are easy to localize

@meodai
Copy link
Contributor Author

meodai commented Sep 13, 2021

english is loaded as default, but other languages or color descriptions can now be loaded via a second argument when initializing the class. Need to add it to the docs, and write some tests still. (i will not start translating it until I have all the english descriptions that I want).

I have decided to not go with i18n @dy because in different languages/cultures colors are perceived differently. So it's not just a key value type of translation situation. Some hsl ranges might be different, depending on the language.

@BradKML
Copy link

BradKML commented Sep 27, 2021

So you are the one making https://github.com/meodai/color-names ? Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants