Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion for package niceties #40

Open
sachinag-zz opened this issue Sep 26, 2015 · 1 comment
Open

suggestion for package niceties #40

sachinag-zz opened this issue Sep 26, 2015 · 1 comment
Labels
code content enhancement needs review

Comments

@sachinag-zz
Copy link

Return the values for the description and the repository URL so that the user knows that their code was correct, which is better than just checking that they exist. This will ensure that the user put their URL in quotes correctly (which I messed up and only fixed when I tried to do lesson 8).

Also, my understanding is that Node 3.* doesn't require READMEs, so perhaps that instruction could be deleted.

I'm just going through this lesson at Node School SF so I'm adding suggestions in real time as we work through. Thanks!
@ashleygwilliams
Copy link
Contributor

thanks @sachinag !! this kind of feedback is perfect. sorry for the delay in response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code content enhancement needs review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sachinag-zz @ashleygwilliams