Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Students confused by "type of String" in if-statement problem #206

Open
fwouts opened this issue Oct 15, 2017 · 7 comments · Fixed by #207
Open

Students confused by "type of String" in if-statement problem #206

fwouts opened this issue Oct 15, 2017 · 7 comments · Fixed by #207

Comments

@fwouts
Copy link
Contributor

fwouts commented Oct 15, 2017

First of all, thanks for making this workshopper!

We facilitated a NodeSchool event in Sydney last weekend, and I saw several students confused by the wording of the following sentence:

Make the fruit variable reference the value orange with the type of String.

It looked like they weren't sure whether they needed to type "String" somewhere.

I'd like to suggest some alternative wordings:

Make the fruit variable reference the string value orange.
Make the fruit variable reference the string value "orange".

Would this help? What do others think?

@AnshulMalik
Copy link
Contributor

Thanks @fwouts I agree,

This looks good to me

Make the fruit variable reference the string value "orange".

PRs welcome

fwouts added a commit to fwouts/javascripting that referenced this issue Oct 17, 2017
This fixes workshopper#206 in English, French, Spanish and Italian.
@itzsaga
Copy link
Member

itzsaga commented Nov 18, 2017

@fwouts took care of 4 translations with #207. Here's is a list to keep track of the rest being updated:

  • en
  • es
  • fr
  • it
  • ja
  • ko
  • nb-no
  • pt-br
  • ru
  • zh-cn
  • zh-tw
  • uk

@singhvisha
Copy link

hi, I want to contribute to this project

@Violet-XiaoWeiHuang
Copy link
Contributor

Hi Seth,
I could contribute to translate in zh-cn.

@itzsaga

@itzsaga
Copy link
Member

itzsaga commented Feb 12, 2019

Awesome @Violet-XiaoWeiHuang, please open a PR with the changes and let us know if you need anything else.

@Violet-XiaoWeiHuang
Copy link
Contributor

#260
Updated the translation for numbers in zh-cn

@ledsun
Copy link
Collaborator

ledsun commented Aug 17, 2019

Other than English, French, Spanish and Italian have not been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants