Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate object keys challenge #267

Open
8 of 12 tasks
ledsun opened this issue Aug 17, 2019 · 6 comments
Open
8 of 12 tasks

Translate object keys challenge #267

ledsun opened this issue Aug 17, 2019 · 6 comments
Labels
help wanted translation

Comments

@ledsun
Copy link
Collaborator

ledsun commented Aug 17, 2019 •
edited

We are looking for contributions to the translation of the “Object Key” challenge.

  • en
  • es
  • fr
  • it
  • ja
  • ko
  • nb-no
  • pt-br
  • ru
  • zh-cn
  • zh-tw
  • uk

Note

  • Please create one PR per language
  • Add your translation of OBJECT KEYS in menu.json into i18n/fr.json or else
  • Add your translation of problems/object-keys/problem_fr.md or else
  • Add your translation of problems/object-keys/solution_fr.md or else
  • Files in problems/introduction directory has been translated. It may be helpful.
lupomontero added a commit to lupomontero/javascripting that referenced this issue Sep 2, 2019
@lupomontero
Adds spanish translation for object-keys exercise workshopper#267
abb7ded 
* Adds translation of OBJECT KEYS in i18n/es.json
* Adds translation of problems/object-keys/problem.md in problems/object-keys/problem_es.md
* Adds translation of problems/object-keys/solution.md in problems/object-keys/solution_es.md
@lupomontero
Copy link
Contributor

Challenge accepted! 😉

We realised the translation for this exercise was missing last saturday in Mexico City:

https://twitter.com/lizita136/status/1167818073031806977

ledsun added a commit that referenced this issue Sep 3, 2019
@ledsun
Merge pull request #270 from lupomontero/translate_object_keys_challenge
161ad4b 
Adds spanish translation for object-keys exercise #267
@dobernike
Copy link

dobernike commented Sep 3, 2019 •
edited

no body on OBJECT KEYS
Please use english version for default, if dont translated;
image

@lupomontero
Copy link
Contributor

@ledsun: can you publish a new release with the spanish translation? we'll be running more workshops soon and it would be really helpful.

I can see some other fixes submitted by @ccarruitero 👍

@ledsun
Copy link
Collaborator Author

ledsun commented Sep 5, 2019

@lupomontero I published 2.6.3!

@ledsun
Copy link
Collaborator Author

ledsun commented Sep 5, 2019

@dobernike
I think

Please use english version for default, if dont translated;

is good idea.
I will fix it, but please wait a moment.

@ledsun
Copy link
Collaborator Author

ledsun commented Sep 12, 2019 •
edited

I did it in 79787dc and 934e8df .

petersonjean added a commit to petersonjean/javascripting that referenced this issue Oct 15, 2019
@petersonjean
Adds french translation for object-keys exercise workshopper#267
e5a6898 
* Adds translation of OBJECT KEYS in i18n/fr.json
* Adds translation of problems/object-keys/problem.md in problems/object-keys/problem_fr.md
* Adds translation of problems/object-keys/solution.md in problems/object-keys/solution_fr.md
ledsun added a commit that referenced this issue Oct 15, 2019
@ledsun
Merge pull request #288 from petersonjean/master
d021ad6 
 Adds french translation for object-keys exercise #267
@j0pgrm j0pgrm mentioned this issue Sep 10, 2022
Closed
@j0pgrm j0pgrm mentioned this issue Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lupomontero @ledsun @dobernike