Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams adventure, not #137

Open
famousgarkin opened this issue May 7, 2015 · 5 comments
Open

Streams adventure, not #137

famousgarkin opened this issue May 7, 2015 · 5 comments

Comments

@famousgarkin
Copy link

Not complaining, nor whining, but the adventure teaches close to nothing about Node.js streams. I'd sum it up as couple examples of Node.js stream-related packages. The tough part was going through quirks of assignment descriptions and packages usage. Expected something along the lines of using and implementing bare Node.js streams. So just a thing to think about, if this is a good direction overall.

@Ntangen
Copy link

Ntangen commented Jul 14, 2015

It's a great set of exercises introducing people to Node and to streams generally, though.

@aleksandarristic
Copy link

This lesson actually only teaches how to use through2.

@kalinchernev
Copy link
Member

Hi @famousgarkin do you have suggestions for the topics?

@mattMillerC
Copy link

I'm not OP but I agree with the points he's making. As someone starting off in Node I'm confused with the different forms Streams take in the API, which is why I was drawn to this workshop. But it really didn't answer any of these questions.
There are some good examples of how to use the different API's but the descriptions here are sparse compared to some of the other NodeSchool workshops. A little more time could be spent discussing the differences between the base stream, transform2, and duplexer2 modules. Why do we need to use duplexer2 here instead of transform2? Why not just use the stream module?
A lot of these questions were answered for me in this article. Maybe try to integrate some of that explanation into this workshop.
Regardless, this workshop was helpful to me. Thanks for your efforts!

@Chrinkus
Copy link

Chrinkus commented Jan 31, 2017

@kalinchernev for me, I would suggest working more within Node's core functionality. Both the Learnyounode & this workshop have the student install through2 to achieve a result that is much easier accomplished within the javascript language.

Aside from that, the exercises that I've completed all do very little to "teach", settling instead for coming just short of providing the answers to their respective problems. I would have preferred the workshop to actually play into the "adventure" theme and challenge the student with more demanding problems.

EDIT: Ok, "Beep Boop" was simple, but the follow up "Meet Pipe" could have been made better by returning an actual file to the stdout with adventure-flavoured content(?). Also perhaps by not actually providing the solution in the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants