Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read_IT instructions need reviewed #250

Open
BenjDG opened this issue Aug 7, 2020 · 4 comments
Open

Read_IT instructions need reviewed #250

BenjDG opened this issue Aug 7, 2020 · 4 comments

Comments

@BenjDG
Copy link

BenjDG commented Aug 7, 2020

The instructions for the "READ IT" exercise break down about halfway through.

Explaining the "Consuming a Readable Stream" and "Adding data to stream" a bit more might help.

Also, using some examples might help. Also, I don't seem to be able to find an solutions to this challenge online yet.

@ccarruitero
Copy link
Contributor

Hi @BenjDG

Thanks for the feedback. The read_it exercise it's a bit new (was introduced around 2 months ago).

I'll try to take a look into how to improve explanation in the sections that you mention, but PR are always welcome :) .

You can found solutions for this exercise in the repository, in the problem's folder and in the problem's test

@gkatsanos
Copy link

This exercise has some issues:
Implement a Readable stream, initiate a new stream instance from your
implementation and pipe to process.stdout. You will receive the content to
add to your stream like first argument.

The last sentence seems auto-translated. Should be : "the input for your stream is given from the 2nd process argument, process.argv[2]."
In addition, you need to state that the values are separated by newline or comma (or both) and mention something about "size".

To be honest I would remove this exercise for now until its a bit more stable.

@BenjDG
Copy link
Author

BenjDG commented Aug 19, 2020

Hey @ccarruitero
Thanks for the response, I was enjoying the 'adventure' until that point and then had to skip it.
I'm new to JavaScript with Nodejs, but have a background in teaching and the instructions just seemed a little confusing.
Thanks for addressing my comments, I really like the format of the 'adventure' from easy to hard.
Keep up the good work!

@ccarruitero
Copy link
Contributor

Hi @gkatsanos

The first argument that you pass throw command line arguments is parsed as process.argv[2] in Node.js.

I'm open to reword the argument sentence, or any other, you are free to open a PR :).

I think the solution was left from an initial implementation that was a bit more complex that how ended up the exercise. To solve the exercise you don't really need to implement the _read method, just need to have one (_read method) in your stream implementation, push the content to your stream and then pipe your stream to stdout.

The solution in tests is enough to solve the exercise

I'll cleanup the reference solution to avoid confusion.

tioback added a commit to tioback/stream-adventure that referenced this issue Sep 1, 2020
Added spaces to prevent word agglutination on terminal.
Changed the argument wording on the challenge to use the same pattern as in the `meet pipe` problem (workshopper#250).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants