Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click "space" and "Enter" from terminal menu, get unhandled 'error': write after end #108

Open
dylanwa opened this issue Apr 21, 2015 · 2 comments
Open

Click "space" and "Enter" from terminal menu, get unhandled 'error': write after end #108

dylanwa opened this issue Apr 21, 2015 · 2 comments

Comments

@dylanwa
Copy link

dylanwa commented Apr 21, 2015

The issue is,

open CMD,
type "learnyounode", the terminal menu display.
now click "space", the menu disappear,
then click "enter",
get below error output:

_events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: write after end
    at writeAfterEnd (C:\Users\<myName>\AppData\Roaming\npm\node_modules\learnyounode\node
_modules\workshopper\node_modules\terminal-menu\node_modules\duplexer2\node_modules\readab
le-stream\lib\_stream_writable.js:161:12)
    at DuplexWrapper.Writable.write (C:\Users\<myName>\AppData\Roaming\npm\node_modules\le
arnyounode\node_modules\workshopper\node_modules\terminal-menu\node_modules\duplexer2\node
_modules\readable-stream\lib\_stream_writable.js:208:5)
    at ReadStream.passDataToMenu (C:\Users\<myName>\AppData\Roaming\npm\node_modules\learn
younode\node_modules\workshopper\menu.js:69:16)
    at ReadStream.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)
    at ReadStream.Readable.push (_stream_readable.js:126:10)
    at TTY.onread (net.js:538:20)_
@dylanwa
Copy link
Author

dylanwa commented Apr 21, 2015

Here is the discussion and 2 guys confirm it's an issue.
nodeschool/discussions#1084 (comment)

@dylanwa dylanwa mentioned this issue Apr 21, 2015
Closed
@TimothyGu
Copy link

I can confirm this as well. Typing "q" instead of "space" results in the same error.

TimothyGu added a commit to TimothyGu/workshopper that referenced this issue Jan 17, 2016
@TimothyGu
Fix menu closing handler
ab7907a 
This commit fixes workshopper#108 in that it prevents the "write after end" error.
However, the terminal is not completely reset after exit through
keyboard due to substack/terminal-menu#30. A fix for that issue is
available at substack/terminal-menu#31.
@TimothyGu TimothyGu mentioned this issue Jan 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix menu closing handler TimothyGu/workshopper
2 participants
@TimothyGu @dylanwa