Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu selection does not work with Node 4 & Windows #120

Open
SomeoneWeird opened this issue Sep 15, 2015 · 11 comments
Open

Menu selection does not work with Node 4 & Windows #120

SomeoneWeird opened this issue Sep 15, 2015 · 11 comments
Labels

Comments

@SomeoneWeird
Copy link
Member

Menu renders but selection is not possible, have confirmed it only happens with node 4 on windows (I tested with 10, but have had reports of 7/8 breaking too)

See nodeschool/discussions#1448

@martinheidegger
Copy link
Contributor

I published a new version of workshopper-adventure, would you mind to try it?

@SomeoneWeird
Copy link
Member Author

@martinheidegger This also affects other workshops like goingnative, so I'm pretty sure it's a bug in workshopper. I tried your latest change and it's still not working.

@martinheidegger
Copy link
Contributor

Workshopper-adventure is a complete fork of workshopper! It doesn't have
much similarity anymore...

On Thursday, September 17, 2015, Adam Brady notifications@github.com
wrote:

@martinheidegger https://github.com/martinheidegger This also affects
other workshops like goingnative, so I'm pretty sure it's a bug in
workshopper. I tried your latest change and it's still not working.


Reply to this email directly or view it on GitHub
#120 (comment)
.

@kbwjosh
Copy link

kbwjosh commented Sep 20, 2015

@SomeoneWeird I agree. Ive tested nodejs vs4.0&4.1 it doesnt work on windows 8.1.
Menu selection doesnt work.

@SomeoneWeird
Copy link
Member Author

nodejs/node#3006 is probably related.

@MexieAndCo
Copy link

Having the described problem (arrow keys do not select menu items), too. learnyounode@2.7.1 in a normal Windows Command Prompt window, Windows 8.1, Node 4.2.1.

@SomeoneWeird
Copy link
Member Author

This has been fixed upstream in node 5.1.0

@martinheidegger
Copy link
Contributor

Yes, it has been fixed in node 5.1.0 but there should be a message in the breaking node versions and a fallback to "non-tty" mode.

@martinheidegger
Copy link
Contributor

In addition: Call for help: It would help a lot of if we had a package that returns "true" if interactive mode in node version is available. A interesting npm name could be supports-cli-interation:

require('supports-cli-interaction') // true or false

@jmbucknall
Copy link

Just a quick addendum: this is again broken in node 5.8.0 (Windows 10, fully updated). I can confirm it works in node 5.3.0 (happened to have it on another machine here, again Windows 10). I have reverted to 5.3.0 for now.

@benjamincarp
Copy link

this appears to also be an issue using the ubuntu for windows 10 bash and node v6.4.0

I also ran node -p -e "Boolean(process.stdout.isTTY)" and it returned true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants