Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to another activation event policy #87

Open
femto-code opened this issue Nov 16, 2022 · 1 comment · Fixed by amac4015/vscode-surround#1
Open

Consider switching to another activation event policy #87

femto-code opened this issue Nov 16, 2022 · 1 comment · Fixed by amac4015/vscode-surround#1

Comments

@femto-code
Copy link

First, thanks for this extension! Just a minor thing: I noticed this extension will be activated whenever VSC starts up.

As the API reference states:

To ensure a great user experience, please use this activation event in your extension only when no other activation events combination works in your use-case.

There are some other similar extensions that use a more specific activation event to activate only when needed (e.g. when a surround command is triggered).

@yatki
Copy link
Owner

yatki commented Nov 19, 2022

Hey @femto-code. Thank you very much for the feedback. Yes, you are totally right and I'm aware of that. When I released the extension, activation events were causing the extension to start with a slight lag. I wanted to avoid that back then.

I totally agree that it's the best practice but since the activation function is only triggered once, and the extension is very lightweight I don't think it's a very big problem at the moment.

I'll look into this and if it's fine, I'll change that.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants