Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator icons for non-public generators #49

Open
keirlawson opened this issue Jul 27, 2015 · 3 comments
Open

Generator icons for non-public generators #49

keirlawson opened this issue Jul 27, 2015 · 3 comments

Comments

@keirlawson
Copy link

My company ships a Yeoman generator for our internal development environment. As such it is hosting on a private NPM repo as it doesn't make sense for anyone outside our company. Using yeoman-app is potentially interesting to us but I am wondering how we can include an icon for our generator, given it's internal nature? I could submit a PR with an image but this would seem a bit odd given that the generator itself isn't public...

@stefanbuck
Copy link
Member

There was an idea to store the images in the generators see #11.

@ruyadorno
Copy link
Contributor

@stefanbuck I take back what I said in that issue, @keirlawson just provided the perfect example where having all images public doesn't really make sense...

I guess having some meta-data in the generator's package.json wouldn't hurt, we could work on a solution for that 👍

@SBoudrias
Copy link
Member

Also, storing the image inside the repo would balloon the size of repos on npm and increase install time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants