Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Trackpad Click counts as thumbstick click #2

Open
ShyAssassin opened this issue Jun 19, 2023 · 8 comments
Open

Index Trackpad Click counts as thumbstick click #2

ShyAssassin opened this issue Jun 19, 2023 · 8 comments

Comments

@ShyAssassin
Copy link

ShyAssassin commented Jun 19, 2023

When using Valve Index Controllers clicking down at the top of the trackpad will start transcription when the start action is set as the thumbtack click in settings.
After snooping around the source code i believe this is because unfortunately like thumbstick actions trackpad actions also fire the same event, unlike with thumbsticks the currently implemented deadzone check will not reliably filter out inputs for trackpads.
Before opening this issue i did try a few things to attempt to fix it so i could open a PR but nothing i could think of worked, it may be worth removing openvr in favor of openxr(pyopenxr) as it has separate events for these actions.

@yum-food
Copy link
Owner

Agreed w/ openxr. openvr is deprecated and the input event filtering is super hacky. Switching libraries is def the move.

FWIW, I personally use the a/b button inputs. This might be a painful but acceptable short-term workaround.

Thanks for the report! I'll try to get to this asap.

@ShyAssassin
Copy link
Author

i did try switching over to using a/b for a while but for some reason griping and pulling my hand back activated it at times, although i think that might be an issue with my SteamVR config

yum-food added a commit that referenced this issue Jun 19, 2023
pyopenvr is deprecated and is causing a user issue
(#2).

That user was kind enough to experiment with different configs and
didn't find a simple fix. So let's close this tech debt issue the right
way.
@yum-food
Copy link
Owner

Spent ~3 hours on this so far. Hitting pause for now.

e689105

Notes to self:

@ShyAssassin
Copy link
Author

In theory an instance created with the XR_MND_headless extension enabled shouldnt need to have a graphics binding.

@yum-food
Copy link
Owner

I have a functional prototype done. Working out the bugs and play-testing today. Unless something surprising comes up, it will be in the next release.

@yum-food
Copy link
Owner

Well, something surprising came up. It seems that two things hold:

  • steamvr is in fact using openvr
  • openvr does not implement openxr's XR_EXTX_overlay

https://steamcommunity.com/app/250820/discussions/8/3783625016029084617/

So, I think openXR is out of the question.

@yum-food
Copy link
Owner

The corollary here is that you can't run an openxr app alongside any other app. The openxr app will kill anything running before it, and anything launched after it will kill the openxr app.

After going over the docs for a couple hours and implementing this a couple different ways, there is simply no way to do it.

So I'll focus on openvr and see if there's a better way to sample joystick clicks.

@ShyAssassin
Copy link
Author

hmmmm interesting i wonder how other overlay apps like OpenVR Advanced Settings or XSOverlay are able to run alongside other applications.
Im going to do some research and see if i can make something, if i am able to i will share the code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants