Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disconnect #25

Open
fantix opened this issue Jul 11, 2014 · 3 comments
Open

Implement disconnect #25

fantix opened this issue Jul 11, 2014 · 3 comments
Labels
Milestone

Comments

@fantix
Copy link
Member

fantix commented Jul 11, 2014

No description provided.

@fantix fantix added this to the v1.0 milestone Jul 11, 2014
@fantix fantix added the task label Jul 11, 2014
@cjdsellers
Copy link

Could you please provide some more description.

@Alexei-Kornienko
Copy link
Collaborator

Currently you have a connect method that allows you to connect to some endpoint. And you also have a close method that is used to completely shutdown the socket. So it may be the need to implement disconnect method that will be used to cancel a connect call and leave other parts intact. It may also be related to automatic reconnects cause it's required by ZeroMQ spec and it's currently missing

Dav1d23 added a commit to Dav1d23/zeromq_connection_not_closed that referenced this issue May 25, 2022
@Dav1d23
Copy link

Dav1d23 commented May 25, 2022

Hello, I'm trying to implement a server using this crate, and I actually fall short of "files" since it seems that the server keeps tasks open even when the client connection is closed. I pushed some test code in https://github.com/Dav1d23/zeromq_connection_not_closed, is it because of the problem stated in this issue?

Thanks!

Edit: I just wanted to add that the provided code is what I've found to be a minimal example: you can run the 2 provided binary, open the tokio-console on the server and check that there are many tasks not "freed" even when the clients are disconnected completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants