Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version numbers broken on macOS #42

Open
core-code opened this issue Jun 28, 2018 · 3 comments
Open

version numbers broken on macOS #42

core-code opened this issue Jun 28, 2018 · 3 comments

Comments

@core-code
Copy link

version 5.1.0 actually claims to be version 1.7.8 when selected in the Finder
@dasmurphy
Copy link

And the icon is also broken.

@core-code
Copy link
Author

regarding the version number:

"build": "electron-packager app SpaceRadar --platform=darwin --arch=x64 --version=1.7.8 --version-string.CompanyName=zz85 --version-string.ProductName=SpaceRadar --icon=Icon.icns",

the problem is this line. it should read
version=5.1.0

zz85 added a commit that referenced this issue Sep 16, 2019
@zz85
Bumped versions
561b5d1 
- SpaceRadar - 5.1.0  -> 5.1.1
- Electron - 1.7.8 -> 1.8.8
- electron-packager - 14.0.6

Also fix icon and version number specified in #42
@Amorymeltzer
Copy link

Not my area of expertise, but seems like 561b5d1 didn't fix the issue, as this is still ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Amorymeltzer @dasmurphy @core-code