Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ThreeJS and Using WebGL Rendering #3

Open
imgurbot12 opened this issue Nov 22, 2023 · 2 comments
Open

Upgrade ThreeJS and Using WebGL Rendering #3

imgurbot12 opened this issue Nov 22, 2023 · 2 comments

Comments

@imgurbot12
Copy link

imgurbot12 commented Nov 22, 2023

Hello, I love the creativity of this project and I plan on using this as inspiration for a personal project of mine using a more recent version of ThreeJS.

As a first test for my own implementation I was trying to see if I could upgrade this project to a more modern version of threejs and use the webgl rendering since the current canvas-renderer is no longer supported.

I've tried my best to follow along with how you've designed things and based my changes from your comments and notes but I'm having trouble getting the code to actually run. At the moment the objects fail to render and I'm not sure what I'm doing wrong.

I'm hoping for your help in finding the issue to hopefully get everything up and running so I might make a pull-request and update the repo to use something more applicable to the updated libraries. You can find the updated code in my fork over at: https://github.com/imgurbot12/threejs-term/tree/feat/webgl

Hope to hear from you soon. Thanks!

@zz85
Copy link
Owner

zz85 commented Dec 17, 2023

hi! thanks for giving this a shot for upgrading to the webgl renderer. currently node-canvas or gl isn't building on my environment, so unless I test this on a different os, I can't run your code.

but looking at your code - perhaps the first thing is to check whether the rendering is failing at gl or canvas. I would remove the animation and attempt to render 1 or 2 frames and see if there's something in the image data and even just render it to the file first.

@imgurbot12
Copy link
Author

Hey, apologies for the slow response but thank you for the information. That's a good idea on where to start.
I've been a bit distracted with other projects at the moment making it difficult to get back to this but I appreciate your help.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants