Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireless Crafting Terminal does not properly consume action on use #7721

Open
shartte opened this issue Mar 8, 2024 · 2 comments
Open

Wireless Crafting Terminal does not properly consume action on use #7721

shartte opened this issue Mar 8, 2024 · 2 comments
Labels
bug Self explanatory?

Comments

@shartte
Copy link
Member

shartte commented Mar 8, 2024

Tested on Forgecraft, Neoforge 1.20.4

@shartte shartte added the bug Self explanatory? label Mar 8, 2024
@Mari023
Copy link
Contributor

Mari023 commented Mar 8, 2024

I did some testing for this in ae2wtlib,
I think this happens because WirelessTerminalItem#use() always returns new InteractionResultHolder<>(InteractionResult.FAIL, is), when it should probably return new InteractionResultHolder<>(InteractionResult.sidedSuccess(level.isClientSide()), is) (which it does on the server)

this should be an easy fix, since checkPreconditions() is only an item check now, so it can be performed on the client side too

@Mari023
Copy link
Contributor

Mari023 commented Mar 8, 2024

it isn't quite as easy as I thought since ae2 does also check the return value of MenuOpener#open(), which is server only...

tho I don't think there is a case where that would return false when checkPreconditions() is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

2 participants