Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options to enable HttpClientCodec.allowDuplicateContentLengths flag #1889

Open
dgolombek opened this issue Jun 23, 2023 · 1 comment · May be fixed by #1890
Open

Add configuration options to enable HttpClientCodec.allowDuplicateContentLengths flag #1889

dgolombek opened this issue Jun 23, 2023 · 1 comment · May be fixed by #1890

Comments

@dgolombek
Copy link
Contributor

We're using AsyncHttpClient to proxy requests, some of which contain multiple Content-Length flags, and for a few different reasons we don't want to remove the duplicates. Currently AHC doesn't allow configuration of that flag, nor is there any easy way to replace the ChannelManager with our own that does what we need. This will require two configuration variables in AHC, since HttpClientCodec doesn't have a builder interface so we'll need to set both parseHttpAfterConnectRequest and allowDuplicateContentLengths (both with defaults of false). I'll submit a PR to implement this.

@hyperxpro
Copy link
Member

Sure, please do a PR. I will be happy to review it. :)

dgolombek pushed a commit to dgolombek/async-http-client that referenced this issue Jun 23, 2023
Allow users to configure HttpClientCodec's
parseHttpAfterConnectRequest and allowDuplicateContentLengths flags.

Fixes AsyncHttpClient#1889
@dgolombek dgolombek linked a pull request Jun 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants