Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the SINE_TABLE array in MathHelper #381

Open
altrisi opened this issue Jul 28, 2022 · 1 comment
Open

Remove the SINE_TABLE array in MathHelper #381

altrisi opened this issue Jul 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@altrisi
Copy link

altrisi commented Jul 28, 2022

Lithium replaces the sin and cos methods in MathHelper, the only two places that access its SINE_TABLE array. That means that the array is unused after that, however it is still kept in memory.

Suggestion to remove it or at least make it an empty array.
@altrisi altrisi added the enhancement New feature or request label Jul 28, 2022
@2No2Name
Copy link
Member

This might cause issues with mods that directly access the field, but I think it is unlikely that any mod does this.

It should be fine to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@altrisi @2No2Name