Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate alloc.enum_values mixins #450

Open
CalvinMT opened this issue Mar 1, 2023 · 4 comments
Open

Seperate alloc.enum_values mixins #450

CalvinMT opened this issue Mar 1, 2023 · 4 comments
Labels
bug Something isn't working enhancement New feature or request good issue report This is an example of a good issue report

Comments

@CalvinMT
Copy link

CalvinMT commented Mar 1, 2023

Is your feature request related to a problem? Please describe.
In order to disable mixin/alloc/enum_values/RedstoneWireBlockMixin, I need to add "mixin.alloc.enum_values": false inside my mod's fabric.mod.json file. However, doing so also disables all other mixins in the same enum_values folder. Because of this, I find myself required to disable AI mixins (mixin.ai.task.launch and mixin.ai.task.replace_streams) which have nothing to do with my mod. Not disabling these AI mixins gives errors pointing towards mixin.ai.task.launch and mixin.ai.task.replace_streams.

Describe the solution you'd like
Place each file in the mixin/alloc/enum_values folder into their own folder so that users can disable them individually.

@CalvinMT CalvinMT added the enhancement New feature or request label Mar 1, 2023
@2No2Name 2No2Name added the bug Something isn't working label Mar 1, 2023
@2No2Name
Copy link
Member

2No2Name commented Mar 1, 2023

Your proposed solution is good, I will do that.
Additionally the dependency of the ai.task mixins will be explicitly stated.

@2No2Name 2No2Name added the good issue report This is an example of a good issue report label Mar 1, 2023
@2No2Name
Copy link
Member

2No2Name commented Mar 4, 2023

Can you show the error message regarding mixin.ai.task...?

@CalvinMT
Copy link
Author

CalvinMT commented Mar 5, 2023

I should have added it in my initial post, sorry.
Here is a log file with the below lines added to the fabric.mod.json file: powerstones_lithium_ai_task_launch.log

"custom": {
    "lithium:options": {
        "mixin.alloc.enum_values": false,
        "mixin.block.redstone_wire": false
    }
}

These errors appeared after trying to load a single player world, right before entering the world.
The errors disappear after adding mixin.ai.task.launch and mixin.ai.task.replace_streams.

Here is the list of mods I had installed when those errors showed up:

  • fabric-api-0.75.1+1.19.3
  • ferritecore-5.1.0-fabric
  • lithium-fabric-mc1.19.3-0.10.4
  • powerstones-2.0.0+1.19.3 (my mod)

@2No2Name
Copy link
Member

I think this might be related to ferritecore, not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good issue report This is an example of a good issue report
Development

No branches or pull requests

2 participants