Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra-dark cracking animation on the sides of grass blocks #2447

Open
muzikbike opened this issue May 2, 2024 · 0 comments
Open

Fix extra-dark cracking animation on the sides of grass blocks #2447

muzikbike opened this issue May 2, 2024 · 0 comments
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link

Request Description

Vanilla bug https://bugs.mojang.com/browse/MC-265667.

When breaking a grass block, the crack animation renders twice on each of the four side faces, making it appear noticeably darker than it otherwise would. This is without a doubt due to each side using two texture planes (one for the base and another for the overlay). This has happened ever since 14w06b, when grass blocks were made to use the new model system.

The expected results here would be for the cracking animation to only be displayed at the normal intensity.

2024-05-02_02 20 07
2024-05-02_02 20 38

A potential solution is provided in the comments of the linked ticket by Ismael Rosillo:
"It would be better to merge overlapping layers when building models on resource reload (so just one layer of the destroy texture is rendered) and cache them as baked faces at BakedModel.java on separate fields, and use them only when textures like "enchant_glint" and "destroy_progress" are being used. I made some tests yesterday and both MC-166101 and MC-265667 (this issue) seem to be fixed."

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels May 2, 2024
@pajicadvance pajicadvance added A-vanilla-issue Area: Vanilla issue and removed S-needs-triage Status: Needs triage labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement
Development

No branches or pull requests

2 participants