Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanctment Glint should be rendered using a custom shader rather than with additional geometry #2497

Open
jellysquid3 opened this issue May 12, 2024 · 1 comment
Open

Enhanctment Glint should be rendered using a custom shader rather than with additional geometry #2497

jellysquid3 opened this issue May 12, 2024 · 1 comment
Labels
T-enhancement Type: Enhancement

Comments

@jellysquid3
Copy link
Member

This would solve a lot of problems with code paths getting de-optimized when it encounters the VertexConsumer that is used for enchantment glints. Additionally, not generating additional geometry on the CPU saves significant time and video memory bandwidth, while fixing issues like #2487 and #2486.
@jellysquid3 jellysquid3 added the T-enhancement Type: Enhancement label May 12, 2024
This was referenced May 12, 2024
Closed
Closed
@muzikbike
Copy link

Could a similar method be used for the block cracking animation if not already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-enhancement Type: Enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jellysquid3 @muzikbike