Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed fil_actors_interface code in forest #4288

Open
hanabi1224 opened this issue May 6, 2024 · 2 comments
Open

Embed fil_actors_interface code in forest #4288

hanabi1224 opened this issue May 6, 2024 · 2 comments

Comments

@hanabi1224
Copy link
Contributor

          We could have a vote maybe. I prefer the interface in forest to 
  1. avoid publishing fil_actor_* crates on every change.
  2. avoid the shim(e.g. miner::SectorOnChainInfo) in the current fil_actors_interface which does not implement LotusJson or JsonSchema and we have to re-define a same one in forest

Originally posted by @hanabi1224 in #4286 (comment)

@LesnyRumcajs
Copy link
Member

No opinion if we acknowledge that nobody else uses fil_actor_states outside of Forest (and its fil_actors_interface), and we don't intend anyone to use it in the future.

@aatifsyed
Copy link
Contributor

I would love for more autogeneration with that codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants