Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV23 tracking #4318

Open
2 of 4 tasks
LesnyRumcajs opened this issue May 13, 2024 · 4 comments
Open
2 of 4 tasks

NV23 tracking #4318

LesnyRumcajs opened this issue May 13, 2024 · 4 comments
Assignees

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented May 13, 2024

Issue summary

Tracking issue for NV23. See official tracker tracker https://github.com/orgs/filecoin-project/projects/113

  • List accepted FIPs,
  • assess whether we need to change anything in Forest (changes are mostly contained in the builtin-actors and/or FVM), and if so, estimate the effort
  • prepare the upgrade skeleton,
  • drive the upgrade across networks

Other information and links

@LesnyRumcajs
Copy link
Member Author

LesnyRumcajs commented May 14, 2024

Accepted FIPs from filecoin-project/FIPs#1005 (comment)

FIP0065 - Ignore built-in market locked balance in circulating supply calculation (FIP)filecoin-project/FIPs#719

Changes in the node, but minimal. We might need to propagate the network version to modules that didn't use it.

FIP0079 - Add BLS Aggregate Signatures to FVM (FIP)filecoin-project/FIPs#840

No changes are required, though we may want to re-use the implemented verify_bls_aggregate.

FIP0082 - Add support for aggregated replica update proofs (FIP)filecoin-project/FIPs#752

Nothing to do on our side.

FIP0084 - Remove Storage Miner Actor Method ProveCommitSectors (FIP Draft)filecoin-project/FIPs#899

Nothing to do on our side, except bundle changes.

FIP0085: Convert f090 Mining Reserve Actor to Keyless Account Actor (FIP Draft) filecoin-project/FIPs#901

f090 will need to be migrated from multisig to keyless account. It should be a simple state migration.

FIP0090: Non-Interactive PoRep (FIP Draft) filecoin-project/FIPs#854

There will be a new proof type and a field in the Policy struct, which would need to get propagated, but apart from that, no major changes.

Summary

All in all, the effort looks small, though there are changes here and there that need to be addressed.

Node changes from:

  • FIP0065,
  • FIP0079 (not required),
  • FIP0090.

State changes from:

  • FIP0085.

@LesnyRumcajs
Copy link
Member Author

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0091.md is planned to be shipped as well, requiring node changes. See the corresponding Lotus PR that implements this FIP filecoin-project/lotus#11969

@arajasek
Copy link

https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0091.md is planned to be shipped as well, requiring node changes. See the corresponding Lotus PR that implements this FIP filecoin-project/lotus#11969

@LesnyRumcajs Does this have an owner yet, and what's the timeline for needing this implemented in Forest? I'm interested in making the contribution if it's not already assigned, but I'll probably be slower than you folks.

@LesnyRumcajs
Copy link
Member Author

@arajasek It was not assigned, and we'd love your contribution, especially given your subject expertise! The timeline is having this implemented before the calibnet upgrade so that Forest can join testing with Lotus on a devnet and butterflynet (and make a release ~1 week before the calibnet upgrade if possible). I added #4366 if you're still interested.

@lemmih lemmih self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants