Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure LotusJson<Option<T>> is marked as optional in the OpenRPC spec #4331

Open
lemmih opened this issue May 16, 2024 · 0 comments
Open

Ensure LotusJson<Option<T>> is marked as optional in the OpenRPC spec #4331

lemmih opened this issue May 16, 2024 · 0 comments

Comments

@lemmih
Copy link
Contributor

lemmih commented May 16, 2024

Does this fix an encountered issue? Perhaps a simple test is in order to verify that LotusJson<Option<T>> encodes/decodes the way we expect. It's a couple of lines of code, but goes a long way, especially if this code is ever touched by somebody else.

I leave this up to you, non-blocking.

Originally posted by @ruseinov in #4330 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant