Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BABE OnDisabled Consensus message #3930

Open
EclesioMeloJunior opened this issue Apr 29, 2024 · 0 comments
Open

Support BABE OnDisabled Consensus message #3930

EclesioMeloJunior opened this issue Apr 29, 2024 · 0 comments
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-low this is mostly nice to have. S-babe issues related to block production functionality. T-feat this issue/pr is a new feature or functionality.

Comments

@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Apr 29, 2024 •
edited

Issue summary

  • This function does not look in the right place, this should be handled by the dot/digest package which interprets the OnDisable message from the block

  • This consensus message should be handled at dot/digest/block_import.go since there we already support fork-awere consensus messages

https://spec.polkadot.network/sect-block-production#defn-consensus-message-babe
@EclesioMeloJunior EclesioMeloJunior added C-complex Complex changes across multiple modules. Possibly will require additional research. S-babe issues related to block production functionality. P-low this is mostly nice to have. T-feat this issue/pr is a new feature or functionality. labels Apr 29, 2024
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Apr 29, 2024
Merged
@EclesioMeloJunior EclesioMeloJunior changed the title Remove SetOnDisabled from the lib/babe/verifier.go Support BABE OnDisabled Consensus message May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-low this is mostly nice to have. S-babe issues related to block production functionality. T-feat this issue/pr is a new feature or functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EclesioMeloJunior