Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease peer reputation on each block sync request to avoid spam #3941

Closed
EclesioMeloJunior opened this issue May 7, 2024 · 0 comments · Fixed by #3953
Closed

Decrease peer reputation on each block sync request to avoid spam #3941

EclesioMeloJunior opened this issue May 7, 2024 · 0 comments · Fixed by #3953
Assignees
@EclesioMeloJunior
Labels
S-network issues related to the dot/network package. T-security this issue/pr covers security sensitive problem.

Comments

@EclesioMeloJunior
Copy link
Member

Issue summary

While syncing I notice that Gossamer node was receiving a lot of block sync requests for repeated block numbers, block sync requests are meant to peers retrieve blocks from other peers in the network, however, as shown in the below image, the Gossamer host was receiving the same message

image

After logging the remote peer id per request we noticed that is a single remote peer that is making this huge amount of requests

image
@EclesioMeloJunior EclesioMeloJunior changed the title Include anti-spam rules to block sync requests Decrease peer reputation on each block sync requests avoiding spammings May 7, 2024
@EclesioMeloJunior EclesioMeloJunior self-assigned this May 7, 2024
@EclesioMeloJunior EclesioMeloJunior added S-network issues related to the dot/network package. T-security this issue/pr covers security sensitive problem. labels May 7, 2024
@EclesioMeloJunior EclesioMeloJunior changed the title Decrease peer reputation on each block sync requests avoiding spammings Decrease peer reputation on each block sync request to avoid spam May 7, 2024
@EclesioMeloJunior EclesioMeloJunior mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
S-network issues related to the dot/network package. T-security this issue/pr covers security sensitive problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dot/sync): prevent block sync request spamming ChainSafe/gossamer
1 participant
@EclesioMeloJunior