Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pkg/trie): Replace unnecesary panics to errors #3942

Open
dimartiro opened this issue May 8, 2024 · 0 comments
Open

(pkg/trie): Replace unnecesary panics to errors #3942

dimartiro opened this issue May 8, 2024 · 0 comments
Assignees
@dimartiro
Labels
S-trie issues related to the pkg/trie package. T-refactor this issue/pr covers refactoring of existing code.

Comments

@dimartiro
Copy link
Contributor

We had to introduce some panics while working on lazy loading trie to simplify the implementation and prevent a bigger refactor.

We should replace those panics to errors to handle the errors gracefully

More context here
@dimartiro dimartiro added S-trie issues related to the pkg/trie package. T-refactor this issue/pr covers refactoring of existing code. labels May 8, 2024
@dimartiro dimartiro self-assigned this May 8, 2024
@dimartiro dimartiro mentioned this issue May 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimartiro dimartiro

Labels
S-trie issues related to the pkg/trie package. T-refactor this issue/pr covers refactoring of existing code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimartiro