fix(storage): Improve get nextkey performance when we have txs #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
axaysagathiya
as code owners
jimjbrettj
approved these changes
May 17, 2024
EclesioMeloJunior
requested changes
May 20, 2024
dimartiro
force-pushed
the
diego/improve-trie_state-next_key
branch
from
08c8d9c
to
b16a9bd
Compare
EclesioMeloJunior
approved these changes
May 21, 2024
P1sar
reviewed
May 21, 2024
P1sar
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improve
TrieStateNextKeyperformance by keeping the keys sorted in memoryTests
make testIssues
closes: #3958
Benchmarks
Primary Reviewer
@jimjbrettj