Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review electra type safety #6799

Open
wemeetagain opened this issue May 16, 2024 · 1 comment
Open

Review electra type safety #6799

wemeetagain opened this issue May 16, 2024 · 1 comment
Labels
prio-high Resolve issues as soon as possible. scope-security Issues that fix security issues: DOS, key leak, CVEs. spec-electra

Comments

@wemeetagain
Copy link
Member

There are some patterns that lead to degraded type-safety.
We should review our codebase, especially things added in electra, for these types of patterns and refactor if possible.

Ideally we can more clearly articulate our findings here into something that can be added to the contributing doc or elsewhere.

is there a way to make this more typesafe?

I'll make an issue for later, but there are some patterns in our code that lead to this kind of bug (that we should clean up later).

Originally posted by @wemeetagain in #6788 (comment)
@philknows philknows added prio-high Resolve issues as soon as possible. scope-security Issues that fix security issues: DOS, key leak, CVEs. spec-electra labels May 17, 2024
@philknows
Copy link
Member

Is this in any way related to #6775 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-high Resolve issues as soon as possible. scope-security Issues that fix security issues: DOS, key leak, CVEs. spec-electra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wemeetagain @philknows