-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Subtitles/CC and 4k tag #917
Comments
Hi, so this should be rather easy to implement. I'd suggest adding the 4k label as well because these 2 fields are both provided by the ytdl-core module and are next to each other. |
Shall I open another issue for 4k label? |
All good. I'm just gonna change the title and add 4k as well. A new issue for this is not really necessary. |
@PrestonN @GilgusMaximus, I'm working on it. |
Happy to work on this one |
Although it would likely be opened in a second issue if at all, maybe in the future integration with live-caption on supported devices could be done to allow (attempted) captions for all videos, even those without YouTube auto-generated captions? |
I've added a comment on the "Live" label in the pull request. Shouldn't be too difficult to implement, however will leave to different ticket. Don't know about the look of the "Live" label as it seems to have an icon left of it. It'll be easier to ditch the icon and use a "text dot" instead. |
Your comment is unrelated to this feature request and if I'm understanding you correctly not something we would be able to do. A quick internet search for "live captions" gave me two separate things:
|
* #917 - Display Subtitles/CC and 4k tag * Display Subtitles/CC and 4k tag - Implement themes * Review comment changes - 4k and subtitle implementation * Changes for review comments * Implementation of "Live" label * Back out duplication of "Live" label * Changes based on code review
Is your feature request related to a usage problem (not a bug)? Please describe.
I think it would be nice if you add a tag Subtitles/CC if a video has them like YouTube website does.
Describe the solution you'd like to see implemented
Display Subtitles/CC tag if a video has them.
Describe alternatives you've considered
YouTube website displays Subtitles tag.
Screenshots
The text was updated successfully, but these errors were encountered: