Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve executor coverage by validating more cases #1881

Open
MitchTurner opened this issue May 6, 2024 · 0 comments
Open

Improve executor coverage by validating more cases #1881

MitchTurner opened this issue May 6, 2024 · 0 comments
Assignees
@MitchTurner

Comments

@MitchTurner
Copy link
Member

We found a bug in our validate_block code that would have been caught if we validated all our produced blocks. That specific case was for how we checked the L1 transactions, they would get added to the partial_block inside of validate_block twice, and thus throwing a false negative error. There are most definitely more cases like that.
@MitchTurner MitchTurner self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitchTurner MitchTurner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MitchTurner