Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using logger when configuration parsing fails #4571

Open
rtm516 opened this issue Apr 15, 2024 · 2 comments · Fixed by #4697
Open

Not using logger when configuration parsing fails #4571

rtm516 opened this issue Apr 15, 2024 · 2 comments · Fixed by #4697
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.

Comments

@rtm516
Copy link
Member

rtm516 commented Apr 15, 2024

When this fails it calls the built in system error log instead of using our logger so on plugin versions it warns about using the plugin logger.

System.err.println(GeyserLocale.getLocaleStringLog("geyser.bootstrap.config.invalid_port"));

@onebeastchris
Copy link
Member

The geyser logger isn't constructed until after the config is read though, so we can't simply switch it out

@onebeastchris onebeastchris added the Confirmed Bug The bug reported is confirmed and able to be replicated. label Apr 17, 2024
@onebeastchris
Copy link
Member

oops, this ain't fixed yet - maybe with the config rewrite :p
But the linked PR does ensure that the geyser logger is always available so we don't need to use system.out.printl()

@onebeastchris onebeastchris reopened this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug The bug reported is confirmed and able to be replicated.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants