-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
escape_string
doesn't appear to be able to keep double-quotes.
#54511
Comments
This is because julia> escape_string(s, (); keep=('"',))
"\"" This does seem to be something that should be at a minimum fixed in the documentation. |
ah, I see, thanks. That was not what I expected, as I figured the 2nd positional arg represented the set of additional characters that would be escaped, on top of the default ones. |
It is mentioned in the docstring:
Do you have suggestions on how this could be made more explicit? |
Ah, thanks, I guess I missed or misunderstood that part of the docstring. I think that part that's not super clear in the docstring is that
Can anyone shed some light as to why it's implemented this way? I'm happy to take a crack at clarifying the docstring, but I think I'd want to include some extra context for the why. |
True. I thought it was clearer to include |
I may be mis-understanding how this is supposed to work, but it doesn't seem that I can prevent
escape_string
from escaping double-quote characters.Note it works as I'd expect for
\n
:From nightly as of May 17:
The text was updated successfully, but these errors were encountered: