Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wallet only segwit capable coins in orderbook method + related bugs #2050

Open
3 tasks
smk762 opened this issue Jan 17, 2024 · 0 comments
Open
3 tasks

Comments

@smk762
Copy link

smk762 commented Jan 17, 2024

Describe the bug
Recently, coins such as LTC and DGB were marked as wallet_only to motivate users to use LTC-segwit and DGB-segwit instead.

This results in the following response from the API when attempting to request the orderbook.
image

Note: The error message in v1 is actually incorrect as LTC was the rel coin, not the base coin. v2 method error is ok.

image

The v2 response has some unexpected data also.
image

This entry specifies LTC, but for an LTC-segwit address. I've confirmed that order was created on 2.0.0-beta_91be151 with LTC-segwit enabled as LTC-segwit, via the start_simple_market_maker_bot method configured as below

image

What do you want

  • It would be nice to be able to query the orderbook for LTC and rather than get an error, see the results for LTC-segwit. In the past requesting either LTC or LTC-segwit would return the same orderbook, though we didnt have one of them marked wallet only so likely this case was never considered.
  • Optionally fix the v1 error message. Not really important though as v2 orderbook method deprecates the old one.
  • Correctly attribute LTC-segwit orders in the orderbook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant