Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sending the maximum amount on the mainnet and allowing for gas fees to refresh cause simulation to fail #24451

Closed
sleepytanya opened this issue May 9, 2024 · 5 comments
Labels
send-swap Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

When attempting to send the maximum amount and waiting for the gas fees to refresh, users encounter a message indicating 'This transaction is likely to fail' instead of seeing the estimated changes. Additionally, the 'Total' section appears due to the simulation failing.

Expected behavior

Transaction estimations and simulations handled accurately.

Screenshots/Recordings

mainnetGasRefreshMax.mov

Steps to reproduce

  1. Go to mainnet
  2. Start Send transaction
  3. Set MAX amount
  4. Click 'Continue'
  5. Allow some time for gas fees to refresh
  6. Notice simulation fails

Error messages or log output

No response

Version

latest build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature labels May 9, 2024
@hjetpoluru hjetpoluru added the Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. label May 9, 2024
@BZahory
Copy link
Contributor

BZahory commented May 17, 2024

This seems more like a confirmations bug

@sleepytanya
Copy link
Contributor Author

@BZahory @ejwessel
Now we can't see if this bug is still happening since we don't have the confirmation screen for send+swap (except for the case when sending ETH -> ETH).

@BZahory
Copy link
Contributor

BZahory commented May 22, 2024

Downgrading from a blocker since we no longer use the confirmations screen

@BZahory BZahory added send-swap and removed swap-send-blocker Issues that block release of the Swap & Send feature labels May 22, 2024
@sleepytanya
Copy link
Contributor Author

This issue doesn't happen on 11.15.5, 11.17.0 and as mentioned above we now bypass the confirmation screen so there is no place for the bug to exist. I never encountered this bug outside of send+swap.
@hesterbruikman

@hesterbruikman
Copy link

Great! So seems we can close these. Please reopen if I've misunderstood this @sleepytanya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-swap Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-wallet-ux type-bug
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

4 participants