Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Attempt to send non-native token on BNB Chain in Firefox results in BigNumberError #24456

Closed
sleepytanya opened this issue May 9, 2024 · 5 comments
Assignees
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. swap-send-blocker Issues that block release of the Swap & Send feature team-wallet-ux type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented May 9, 2024

Describe the bug

Attempt to send non-native token on BNB Chain results in BigNumberError. This behavior is observed on Firefox only.
This bug seems to be specific to Solana token. Other tokens might be affected as well but I haven't checked all of them.
Disabling and enabling extension, reloading doesn't solve the problem. MetaMask has to be re-installed.

Expected behavior

Screenshots/Recordings

solanaDogeErr.mov

Steps to reproduce

  1. Switch to BNB Chain
  2. Start Send transaction
  3. Select Solana to send and Dogecoin for recipient to receive
  4. See the error

Error messages or log output

Error details

    Message: times() number type has more than 15 significant digits: 143.8296729040208

    Code: BigNumber Error
    Stack:

    Error@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/scripts/runtime-lavamoat.js:8007:17
    ee@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-2.js:14:258011
    q@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-2.js:14:256238
    L.mul@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-2.js:14:267589
    n.useBalanceChanges/T<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-6.js:1:361617
    n.useBalanceChanges/T<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-6.js:1:361438
    n.useBalanceChanges@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-6.js:1:361697
    n.SimulationDetails@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-6.js:1:356441
    ba@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:140802
    Ja@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:149010
    Is@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:186806
    Au@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:171543
    Ru@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:171466
    Tu@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:168814
    eo/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127212
    n.unstable_runWithPriority@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:3:13694
    Qi@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:126921
    eo@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127159
    Ji@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127092
    yu@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:165580
    Aa@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:144461
    r/</<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-5.js:1:281467
    promise callback*r/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-5.js:1:281454
    ks@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:159217
    Bu@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:183730
    n.unstable_runWithPriority@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:3:13694
    Qi@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:126921
    $u@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:183491
    Tu@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:168737
    eo/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127212
    n.unstable_runWithPriority@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:3:13694
    Qi@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:126921
    eo@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127159
    Ji@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:127092
    xu@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:169108
    notify@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:263225
    t.notifyNestedSubs@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:262791
    t.handleChangeWrapper@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:262859
    g@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:313181
    r/</</<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:311199
    setupProxy/n/e[t]@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/scripts/sentry-install.js:1:693
    dispatch@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:314158
    K/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-8.js:1:279879
    r/</</<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:311190
    O/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-5.js:1:330387
    onNotification/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-9.js:1:410401
    r@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-0.js:1:660525
    emit@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-0.js:1:660930
    handleResponse@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/ui-9.js:1:410894
    a.prototype.emit@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:119731
    w@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:282758
    v@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:282573
    y.prototype.push@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:283387
    _write@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-4.js:26:315830
    y@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:295998
    g.prototype.write/a<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:299180
    g.prototype.write@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-5.js:1:299206
    l@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:168244
    a.prototype.emit@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:119731
    H@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:161926
    U@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:161656
    F.prototype.push@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:162256
    _onMessage@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:123299
    i/<@moz-extension://f40e00f6-3ab0-4346-9c9d-fce7ac56fb2b/common-3.js:21:123095

Version

latest build

Build type

None

Browser

Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature labels May 9, 2024
@hjetpoluru hjetpoluru added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-assets team-extension-platform and removed team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature team-assets labels May 9, 2024
@hjetpoluru
Copy link
Contributor

This issue happens only in the firefox and hence assigned to team-extension-platform.

@sleepytanya
Copy link
Contributor Author

@hjetpoluru
This bug appears to have been introduced by recent send+swap PRs and is not present in the develop branch or in production. To ensure this issue receives the focused attention it requires, I'll be reapplying the send+swap label and reassigning it to the wallet UX team.
Thank you, Harika! Here is the FF production video:

bnbFirefox.mov

@sleepytanya sleepytanya added team-wallet-ux swap-send-blocker Issues that block release of the Swap & Send feature send-swap and removed Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform swap-send-blocker Issues that block release of the Swap & Send feature send-swap labels May 9, 2024
@hjetpoluru
Copy link
Contributor

Thanks Tanya.

@gauthierpetetin gauthierpetetin added the Sev2-normal Normal severity; minor loss of service or inconvenience. label May 13, 2024
@ejwessel ejwessel self-assigned this May 16, 2024
@sleepytanya
Copy link
Contributor Author

sleepytanya commented May 18, 2024

@ejwessel @BZahory
I'm not seeing the issue on the latest build:

nonNativeBnb.mov

@BZahory
Copy link
Contributor

BZahory commented May 20, 2024

@ejwessel @BZahory I'm not seeing the issue on the latest build:

nonNativeBnb.mov

Awesome! Closing

@BZahory BZahory closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. swap-send-blocker Issues that block release of the Swap & Send feature team-wallet-ux type-bug
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

5 participants