Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signature redesign ui_customizations metric #24484

Merged
merged 4 commits into from May 14, 2024
Merged

fix: signature redesign ui_customizations metric #24484

merged 4 commits into from May 14, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented May 10, 2024 •
edited by github-actions bot

Description

Open in GitHub Codespaces

Related issues

Fixes: #24483

Manual testing steps

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. enable Experimental > Redesign Confirmation in settings
  3. enable Participate in MetaMetrics in settings
  4. test signatures
  5. observe Signature <Rejected|Canceled|Approved> event with new ui_customization

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand added the team-confirmations Push issues to confirmations team label May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

digiwand
digiwand commented May 10, 2024
View reviewed changes
app/scripts/lib/createRPCMethodTrackingMiddleware.js
const isConfirmationRedesign =
isConfirmationRedesignEnabled() &&
[...REDESIGN_APPROVAL_TYPES, ...REDESIGN_TRANSACTION_TYPES].find(
(type) => type === method,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the redesign transaction types check because it does not work. We will handle this with #24486

@digiwand digiwand marked this pull request as ready for review May 10, 2024 18:00
@digiwand digiwand requested a review from a team as a code owner May 10, 2024 18:01
cryptotavares
cryptotavares previously approved these changes May 10, 2024
View reviewed changes
jpuri
jpuri previously approved these changes May 12, 2024
View reviewed changes
@digiwand digiwand dismissed stale reviews from jpuri and cryptotavares via 39f5866 May 13, 2024 16:33
@digiwand
Copy link
Contributor Author

sorry I should start running yarn lint locally before requesting reviews 🤦🏼‍♀️ @cryptotavares @jpuri

@metamaskbot
Copy link
Collaborator

Builds ready [39f5866]
Page Load Metrics (2093 ± 724 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722071213718
domContentLoaded94017105
load59421020931507724
domInteractive94017105
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 438 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (98d5ff2) to head (39f5866).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24484      +/-   ##
===========================================
+ Coverage    67.47%   67.49%   +0.01%     
===========================================
  Files         1288     1288              
  Lines        50154    50151       -3     
  Branches     13023    13018       -5     
===========================================
+ Hits         33841    33845       +4     
+ Misses       16313    16306       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand digiwand merged commit 26d38d9 into develop May 14, 2024
72 checks passed
@digiwand digiwand deleted the fix-signature-redesign-ui-customization-valid-types branch May 14, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 14, 2024
@digiwand digiwand removed the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@cryptotavares cryptotavares Awaiting requested review from cryptotavares

Assignees
No one assigned
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Internal Bug] Signature Redesign - ui_customization method is not added to event for certain signature types
5 participants
@digiwand @metamaskbot @jpuri @pedronfigueiredo @cryptotavares