-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change as well the location where abiBuiltin is call. From src/transpiler.ts
to src/passes/builtinHandler/index.ts
Could you please provide some more information on this one? |
Hi @jeetabhi01 , sorry for not being clear. The way Warp work is that through several passes we handle different parts of the Solidity source code. One of those passes handle all builtins. When the pass that handled the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try to run tests locally as well, for faster debugging
src/passes/builtinHandler/index.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to execute the ABIBuiltint
pass in the map
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the pass in the map function but yarn test:examples
gave an error. @rodrigo-pino Please have a look in the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected error during transpilation
Error: Unknown pass key: Abi in pass prerequisite of Events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes a pass requires that the AST to be already modified in certain way to guarantee it's correct execution. What's happening here is that there is a pass that required the abi
pass, but since it is now inside the pass that handle all builtins it won't get detected.
You should find every pass that required the abi pass, change that requirement for the builtin pass instead.
Bumps [webpack](https://github.com/webpack/webpack) from 5.73.0 to 5.76.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.73.0...v5.76.1) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor * case typo in import * comments * comments on replaceIndexAccessBytesConverter * changes in utils * lint * changes in updateTypeStringBytesConverter * `selectWarplibFunction` receive `typeNode` arguments
* test2 * discordbadgeee * added discord and twitter badges * created installation.md * created contributing.md * Rename contributing.md to contributingg.md * Update readme.md * Update and rename contributingg.md to contributing, devloping tips and testing.md * Update readme.md * Rename contributing, devloping tips and testing.md to Contributing and testing.md * Rename Contributing and testing.md to Contributing.md * Update readme.md * Update readme.md * Merge Contributing.md and CONTRIBUTING.md * Contributing.md -> contributing.md * Fix links * Add note * Update readmesssss * Some fixes * Changes * Update contributing.md Co-authored-by: Jorik Schellekens <joriksch@gmail.com> * Update contributing.md Co-authored-by: Jorik Schellekens <joriksch@gmail.com> * Update contributing.md * More changes" * Behaviour Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * Behaviour II Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * remove rogue ñ Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * generic path Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * Minor update to contributing * Update readme * interpreted modes Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * Update contributing.md Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * Update contributing.md Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> * Update contributing.md * fixes * in a separate terminal Co-authored-by: Carmen Irene Cabrera Rodríguez <49727740+cicr99@users.noreply.github.com> --------- Co-authored-by: coeuskoalemoss <siddhi.kommuri@somaiya.edu> Co-authored-by: Siddhi kommuri <84127077+coeuskoalemoss@users.noreply.github.com> Co-authored-by: Jorik Schellekens <joriksch@gmail.com> Co-authored-by: Piotr Piwoński <piwonskp@gmail.com> Co-authored-by: Carmen Irene Cabrera Rodríguez <49727740+cicr99@users.noreply.github.com>
@jeetabhi01 do you need any more help, how it is going? |
Oh I am sorry for late reply,
|
Moved abibuiltins to builtinHandler directory.
resolves #1023