Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Add Siera→CASM stage to compilation tests #1062

Open
temyurchenko opened this issue May 19, 2023 · 0 comments
Open

Add Siera→CASM stage to compilation tests #1062

temyurchenko opened this issue May 19, 2023 · 0 comments

Comments

@temyurchenko
Copy link
Contributor

Background

At the moment we have several test-suites.
Compilation tests check that transpiled files compile from Cairo to Sierra as expected.
Behavioural tests check that compiled and deployed contracts behave as expected.
Compilation tests are simpler to create and faster to run, but behavioural tests are more comprehensive.

Problem

Compilation tests are not quite as useful as they can be. The way we do it know, some (I assume a non-trivial amount) of errors slip through. For example, our tests report successful compilation of absolutely any address literal, even if it doesn't fit the allowed range. Only the next, Sierra→CASM stage reports such an error.

Solution

Check Sierra→CASM compilation stage in compilation tests as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant