This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Fix warpmemory function naming and implicits + other minor stuff #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1063 #1064
Also fix other minor bugs found in Warp while updating
Add a compilation test
The reason this PR haven't been merged is because the existence of an unexpected behaviour on the cairo compiler after the compilation stage. By compiling the test at tests/compilation/contracts/warpMemorySystems/implicitPropagation.sol we get:
It is odd because all the independent components used by the transpiled contract have been tested.
We should look help from Starknet to see what is causing this error, or expect that a future release of Cairo won't have this behaviour